-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Cosmos changes in 9.0 #4812
Conversation
612025f
to
04b50eb
Compare
31269c1
to
e25d9bc
Compare
@Pilchie - fyi |
Also tagging @jcocchi and @kirankumarkolli here. |
entity-framework/core/what-is-new/ef-core-9.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
entity-framework/core/what-is-new/ef-core-9.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
entity-framework/core/what-is-new/ef-core-9.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
| [Undefined results are now automatically filtered from query results](#cosmos-undefined-filtering) | Medium | | ||
| [Incorrectly translated queries are no longer translated](#cosmos-incorrect-translations) | Medium | | ||
| [`HasIndex` now throws instead of being ignored](#cosmos-hasindex-throws) | Low | | ||
| [`IncludeRootDiscriminatorInJsonId` was renamed to `HasRootDiscriminatorInJsonId` after 9.0.0-rc.2](#cosmos-IncludeRootDiscriminatorInJsonId-rename) | Low | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding #4804 as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, didn't notice that one... But will leave it for you :)
At this point, if you wish, you can also update all your documents to use the new `$type` naming. | ||
|
||
TODO: Cosmos SDK code sample for updating the documents | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To really help people out with these two high-impact breaking changes, we should ideally include some code with the Cosmos SDK (not EF) to just rename Discriminator
-> $type
, and remove the discriminator from id
... @AndriySvyryd is this something you're with doing, or maybe can see if someone else in the team can?
Removing the TODO for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #4821
entity-framework/core/what-is-new/ef-core-9.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
|
||
### Role-based access | ||
|
||
Azure Cosmos DB for NoSQL includes a [built-in role-based access control (RBAC) system](/azure/cosmos-db/role-based-access-control). This is now supported by EF9 for both management and use of containers. No changes are required to application code. See [Issue #32197](https://github.com/dotnet/efcore/issues/32197) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Management operations with RBAC aren't supported, see other comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave this out of this PR - I didn't touch this section and am not sure I'm totally familiar with the whole thing... Do we have an issue do make RBAC-related doc changes?
707d334
to
3b87f50
Compare
Closes dotnet#4808 Part of dotnet#4805 (new function translations for Cosmos)
This is a pretty huge PR which takes care of the Cosmos documentation for 9.0. There's tons of new content and reorganization of existing content - some reviewing from everyone would be appreciate to catch issues etc.
Closes #4808
Part of #4805 (new function translations for Cosmos)